Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] BlockDisplay should use BLOCK_STATE not INT #13

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[Fix] BlockDisplay should use BLOCK_STATE not INT #13

merged 1 commit into from
Jul 8, 2024

Conversation

akshualy
Copy link
Contributor

@akshualy akshualy commented Jul 8, 2024

For BlockDisplay blocks to display, we need to send a BLOCK_STATE and not a regular INT. Client can not parse integer to block state so it disconnects itself.

Relevant wiki.vg entry:
https://wiki.vg/Entity_metadata#Block_Display

@Bram1903 Bram1903 requested a review from Tofaa2 July 8, 2024 13:39
@Bram1903 Bram1903 added the bug Something isn't working label Jul 8, 2024
@Bram1903 Bram1903 changed the title BlockDisplay should use BLOCK_STATE not INT [Fix] BlockDisplay should use BLOCK_STATE not INT Jul 8, 2024
Bram1903
Bram1903 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@Bram1903 Bram1903 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tofaa2 Tofaa2 merged commit 59bb99b into Tofaa2:master Jul 8, 2024
@akshualy akshualy deleted the fix/block-display-meta-data-type branch July 8, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bram1903 Bram1903 Bram1903 approved these changes

@Tofaa2 Tofaa2 Tofaa2 approved these changes

Assignees

@akshualy akshualy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshualy @Bram1903 @Tofaa2