-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: Remove useless if clause #2717
Conversation
f5e6dc3
to
5857c13
Compare
5857c13
to
7c49ea5
Compare
Are you sure you want to make (even possibly no-op) logic changes in the current release? |
Nope, we can move it to the next release. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2717 +/- ##
==========================================
- Coverage 73.04% 73.03% -0.01%
==========================================
Files 149 149
Lines 30533 30531 -2
==========================================
- Hits 22302 22298 -4
- Misses 8231 8233 +2 ☔ View full report in Codecov by Sentry. |
Converted it to a draft to prevent an accidental auto-merge by someone reviewing it. |
4c09a42
to
78f6332
Compare
78f6332
to
de167dd
Compare
de167dd
to
fa20168
Compare
This change is