Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove useless if clause #2717

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Feb 28, 2024

This change is Reviewable

@JFreegman JFreegman added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Feb 28, 2024
@JFreegman JFreegman added this to the v0.2.19 milestone Feb 28, 2024
@JFreegman JFreegman force-pushed the redundant_clause branch 2 times, most recently from f5e6dc3 to 5857c13 Compare February 28, 2024 14:33
@JFreegman JFreegman marked this pull request as draft February 28, 2024 14:34
@iphydf
Copy link
Member

iphydf commented Feb 28, 2024

Are you sure you want to make (even possibly no-op) logic changes in the current release?

@JFreegman JFreegman marked this pull request as ready for review February 28, 2024 14:42
@JFreegman JFreegman modified the milestones: v0.2.19, v0.2.20 Feb 28, 2024
@JFreegman
Copy link
Member Author

Are you sure you want to make (even possibly no-op) logic changes in the current release?

Nope, we can move it to the next release.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.03%. Comparing base (7572888) to head (fa20168).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
- Coverage   73.04%   73.03%   -0.01%     
==========================================
  Files         149      149              
  Lines       30533    30531       -2     
==========================================
- Hits        22302    22298       -4     
- Misses       8231     8233       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nurupo nurupo marked this pull request as draft March 2, 2024 03:47
@nurupo
Copy link
Member

nurupo commented Mar 2, 2024

Converted it to a draft to prevent an accidental auto-merge by someone reviewing it.

@JFreegman JFreegman force-pushed the redundant_clause branch 2 times, most recently from 4c09a42 to 78f6332 Compare March 7, 2024 18:30
@JFreegman JFreegman marked this pull request as ready for review March 28, 2024 01:24
@toktok-releaser toktok-releaser merged commit fa20168 into TokTok:master Mar 28, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants