chore: Fix Circle CI build failing #2755
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circle CI's image got updated to use Ubuntu 24.04 (Noble Numbat), which:
libclang_rt.ubsan_standalone-x86_64.a
is no longer getting installed-Wswitch-default
and-Wunsafe-buffer-usage
:We actually do not want a default in our switches, we want to explicitly handle every case and get warned when we don't, so
-Wswitch-default
should be disables-Wunsafe-buffer-usage
seems to be broken, it warns on things that are perfectly ok, like doingfoo[1] = 0;
whereuint32_t foo[4];
, e.g.warning:
on:
c-toxcore/toxcore/network.c
Line 966 in da43876
where
uint32
is:c-toxcore/toxcore/network.h
Line 200 in da43876
This change is