Added extension icon #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/src/icon.png -- 12.62kb -> 10.88kb (13.76%)
[ImgBot] Optimize images
Tom-Bonnike
previously approved these changes
Mar 3, 2019
Tom-Bonnike
dismissed
their stale review
Actually no, the img should be at the root of the project.
|
Hey, thank you for this PR! ❤️
I’m guessing the icon itself will look more crisp when scaled down to 128x128 by VSCode, thanks for uploading a retina version. |
|
Hey. Thanks for the feedback. I’ll update the icon’s outer circle and the path in the package.json tomorrow morning. |
|
Thaaanks! Just for clarity, the path in the package.json is correct but you put the icon in the |
Tom-Bonnike
approved these changes
Mar 12, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #39
If you'd like to suggest any changes, please let me know.
I think the path in
package.jsonmight need to be different, but I'm not certain.