Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the extension to make the code simpler and more robust #50

Merged
merged 3 commits into from
Oct 10, 2019
Merged

Rewrite the extension to make the code simpler and more robust #50

merged 3 commits into from
Oct 10, 2019

Conversation

Tom-Bonnike
Copy link
Owner

@Tom-Bonnike Tom-Bonnike commented Oct 6, 2019 •
edited
Loading

On top of rewriting the whole extension to make it simpler to work with, this PR:

  • Removes unneeded dependencies, updates dependencies and fixes npm vulnerabilities.
  • Stops using the extension context global state to pass values around since it wasn’t needed and made the code more complicated than it should have been. It also fixes doesn't work with multiple vscode windows  #46, making sure the status bar text is synced across all vscode windows. This was caused by the SHOULD_IGNORE_CONFIGURATION_CHANGES global state.

Adds integration tests using vscode-test Nevermind, the testing setup is terrible for vscode extensions.

@Tom-Bonnike Tom-Bonnike self-assigned this Oct 6, 2019
@Tom-Bonnike Tom-Bonnike changed the title Rewrite the extension to make the code simpler Rewrite the extension to make the code simpler and less hacky Oct 6, 2019
@Tom-Bonnike Tom-Bonnike changed the title Rewrite the extension to make the code simpler and less hacky Rewrite the extension to make the code simpler and more robust Oct 6, 2019
@Tom-Bonnike Tom-Bonnike force-pushed the rewrite-extension branch 5 times, most recently from 3849c7b to 5110dab Compare October 6, 2019 21:02
@Tom-Bonnike Tom-Bonnike changed the title Rewrite the extension to make the code simpler and more robust Rewrite the extension to make the code simpler and more robust, and add integration tests Oct 6, 2019
@Tom-Bonnike Tom-Bonnike added the WIP label Oct 6, 2019
@Tom-Bonnike Tom-Bonnike force-pushed the rewrite-extension branch 16 times, most recently from dfaceea to 58ce821 Compare October 10, 2019 14:20
@Tom-Bonnike Tom-Bonnike changed the title Rewrite the extension to make the code simpler and more robust, and add integration tests Rewrite the extension to make the code simpler and more robust Oct 10, 2019
@Tom-Bonnike Tom-Bonnike removed the WIP label Oct 10, 2019
@Tom-Bonnike Tom-Bonnike merged commit 0ce8c60 into master Oct 10, 2019
@Tom-Bonnike Tom-Bonnike deleted the rewrite-extension branch October 10, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tom-Bonnike Tom-Bonnike

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doesn't work with multiple vscode windows
1 participant
@Tom-Bonnike