New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully remove non equi non pit condition #10

Merged

Tom-Newton merged 4 commits into tom-main from tomnewton/remove_non_equi_non_pit_condition

Jan 17, 2024

Owner

Tom-Newton commented Jan 17, 2024

Spark PIT does not support non-equi conditions beside the PIT column.

Make this more explicit by failing during query plan
Remove some unneeded code designed to handle these during execution. I assume this is more legacy of the original sort merge join.
Add a test asserting a failure

Tom-Newton added 4 commits

January 17, 2024 00:37


          Remove condition from exec code

bd5050b


          Fail physical planning if there are non-equi conditions

0a8322f


          Add test

0966a28


          Throw an exception

bf3c536

Tom-Newton merged commit 67a454e into tom-main

Tom-Newton deleted the tomnewton/remove_non_equi_non_pit_condition branch

August 14, 2024 12:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet