Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an orientation option to CTkSegmentedButton #2333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PhilipNelson5
Copy link

@PhilipNelson5 PhilipNelson5 commented Mar 26, 2024

This feature adds the option vertical=False to the CTkSegmentedButton constructor. A "vertical" segmented button uses a vertical layout instead of the default horizontal layout.

Partially addresses #852

@dipeshSam
Copy link

dipeshSam commented Mar 26, 2024

@PhilipNelson5 Way better. Keep it up. 💯

@PhilipNelson5
Copy link
Author

@TomSchimansky is the official documentation source available for MRs? I'd be happy to update the docs for this feature if it is accepted.

@PhilipNelson5
Copy link
Author

PhilipNelson5 commented Mar 26, 2024

I just noticed that progressbar and scrollbar uses the convention orientation="horizontal" or "vertical", I'll update this to be consistent.

@PhilipNelson5 PhilipNelson5 changed the title Add a vertical option to CTkSegmentedButton Add a orientation to CTkSegmentedButton Mar 27, 2024
@Anonymous6598
Copy link

That's good feature

@PhilipNelson5 PhilipNelson5 changed the title Add a orientation to CTkSegmentedButton Add an orientation option to CTkSegmentedButton Mar 27, 2024
@PhilipNelson5
Copy link
Author

@TomSchimansky how does this look?

@MackNcD
Copy link

MackNcD commented Apr 5, 2024

@PhilipNelson5 Thank you, right in the nick of time, for me! Starred your projects for recognition
@TomSchimansky Please absorb to the master after reviewing!

@PhilipNelson5
Copy link
Author

@TomSchimansky any word on getting this accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants