Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force having a pause hotkey #243

Closed
Avasam opened this issue Jun 6, 2023 · 0 comments · Fixed by #248
Closed

Don't force having a pause hotkey #243

Avasam opened this issue Jun 6, 2023 · 0 comments · Fixed by #248
Assignees
@Avasam
Labels
enhancement New feature or enhancement request Included in next release

Comments

@Avasam
Copy link
Collaborator

Avasam commented Jun 6, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
From @shenef on discord:

I'd prefer doing resets and pauses manually and don't really like having keyboard binds for them since on a 65% keyboard I run into hotkey overlap much sooner

Describe the solution you'd like
"pause" hotkey is as optional as "undo"/"redo". I'd keep "reset" as I'd rather regular users not forget it

Let's also validate that sending any command with a missing hotkey does not cause issue.

Alternatively, we could also only enforce pause if there are images that use it

Describe alternatives you've considered
N/A

Additional context
@Avasam Avasam added the enhancement New feature or enhancement request label Jun 6, 2023
Avasam added a commit that referenced this issue Jun 21, 2023
@Avasam
Fix hotkey checking on start
0872cbd 
reset hotkey for reset image wasn't properly being checked
start image only needs to check for start hotkey
start image now also checked on start
Closes #243
@Avasam Avasam self-assigned this Jun 21, 2023
Avasam added a commit that referenced this issue Jun 23, 2023
@Avasam
Fix hotkey checking on start
9fb9a42 
reset hotkey for reset image wasn't properly being checked
start image only needs to check for start hotkey
start image now also checked on start
Closes #243
@Avasam Avasam mentioned this issue Jul 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Avasam Avasam

Labels
enhancement New feature or enhancement request Included in next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.2.0 release Toufool/AutoSplit
1 participant
@Avasam