Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Arm's ProfiledPIDController on the Shuffleboard #13

Open
blu28 opened this issue Feb 25, 2023 · 2 comments
Open

Put Arm's ProfiledPIDController on the Shuffleboard #13

blu28 opened this issue Feb 25, 2023 · 2 comments
Labels
advanced Suitable for more advanced robot programers.

Comments

@blu28
Copy link
Contributor

blu28 commented Feb 25, 2023

All sendables should be on the Shuffleboard.

This one is a little bit tricky, since the controller is passed into the superclass constructor without assigning it. The super call must be the first statement in the constructor, so assigning it in the constructor before calling super is out. Making it a private field might be possible, but it can't be an instance object since instance objects don't get instantiated until after the constructor is run. It might be possible to make it a class object with static.

Another approach would be to create it in RobotContainer and pass it in as a constructor parameter. This follows the same signature as the superclass, so it seems logical.

Another approach would be to see if it is possible to retrieve the controller from the subsystem after it is constructed.

@blu28
Copy link
Contributor Author

blu28 commented Feb 25, 2023

Of course, we would also want the ArmPidSubsystem on the Shuffleboard. Perhaps a class that is an extension of the class ProfiledPIDSubsystem will automatically put the controller on the Shuffleboard if the subsystem is placed there?

@blu28 blu28 added the advanced Suitable for more advanced robot programers. label Feb 25, 2023
@VeraMangahas
Copy link
Collaborator

The PID was put on the shuffleboard yesterday so that part is completed. However, it was asked to be displayed as % to be more user-friendly, so that is the next step to be completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
advanced Suitable for more advanced robot programers.
Projects
None yet
Development

No branches or pull requests

2 participants