Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error output when creating a town #7537

Closed
Theorenter opened this issue Jul 31, 2024 · 0 comments · Fixed by #7538
Closed

Incorrect error output when creating a town #7537

Theorenter opened this issue Jul 31, 2024 · 0 comments · Fixed by #7538
Assignees
@Warriorrrr
Labels
bug Completed
Milestone
0.100.4.0

Comments

@Theorenter
Copy link

What steps will reproduce the problem?

  1. To repeat this, you need to enable biomre_rules in the configurations. In my example, the error is triggered when blocking oceans is enabled.
  2. Connect to the server, find a chunk with an ocean in the world that corresponds to the set value of the 'threshold' configuration parameter.
  3. When you trying to create a new town you get an incorrect error message:
    err

What is the expected output?

A message should be displayed instead of the "msg_err_cannot_begin_town_in_this_biome" translation key.

Towny version

0.100.3.3

Server version

paper-1.21-108

Please use Pastebin.com to link the following files

–
@Theorenter Theorenter added the bug label Jul 31, 2024
@Theorenter Theorenter changed the title Incorrect error output when creating a city Incorrect error output when creating a town Jul 31, 2024
@Warriorrrr Warriorrrr mentioned this issue Jul 31, 2024
Merged
1 task
@LlmDl LlmDl added this to the 0.100.4.0 milestone Aug 1, 2024
LlmDl added a commit that referenced this issue Aug 1, 2024
@LlmDl
- Fix untranslated lang key from unwanted biome claiming, courtesy of
285c81c 
Warrior with PR #7538.
    - Closes #7537.
  - Support custom biomes with the unwanted biomes feature, courtesy of
Warrior with PR #7540.
  - Fix worldcoord upper corners being in another worldcoord, courtesy
of Warrior with PR #7539.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Warriorrrr Warriorrrr

Labels
bug Completed
Projects
None yet
Milestone
0.100.4.0
Development

Successfully merging a pull request may close this issue.

Fix untranslated lang key from unwanted biome claiming TownyAdvanced/Towny
3 participants
@LlmDl @Warriorrrr @Theorenter