Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten target name to maliput::test_utilities #368

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Nov 20, 2020

It's currently maliput::maliput_test_utilities.

This will require changes to downstream packages. I'm going to take this opportunity to add support for checking out matching branch names in GitHub actions, so I've marked this as a draft PR. I'll mark it as ready for review once we have established that checking out matching branch names works properly.

Relates to maliput/maliput_infrastructure#146

It's currently maliput::maliput_test_utilities.
This will require changes to downstream packages.
agalbachicar
agalbachicar previously approved these changes Nov 24, 2020
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scpeters scpeters marked this pull request as ready for review November 24, 2020 17:56
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scpeters scpeters merged commit fcfc981 into master Nov 24, 2020
@scpeters scpeters deleted the scpeters/shorten_maliput_test_utilities_target_name branch November 24, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants