Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor editor.js #106

Closed
alguerre opened this issue Sep 18, 2021 · 0 comments · Fixed by #107
Closed

Refactor editor.js #106

alguerre opened this issue Sep 18, 2021 · 0 comments · Fixed by #107
Assignees
Labels
editor Editor task refactor Code cleaning and refactor

Comments

@alguerre
Copy link
Collaborator

alguerre commented Sep 18, 2021

Problems in code v0.1.3

  • An API call to get the links is needed when all these data are present in segments.
  • Re-do links when removing one segment is too time-comsuming.
  • The manage_track_names function take too much responsability on removal segments.

Why to do a full refactor?

  • It is a module which must be expanded
  • Bug solving takes too much time
  • Performance improvements are needed, current naive approaches has drive to a coupled code.

Solution

  • Create a proper data structure to store tracks, map, chart and links.
  • Make these structures global, at each point no two different methods needs to have simultaneous access.
@alguerre alguerre added editor Editor task refactor Code cleaning and refactor labels Sep 18, 2021
@alguerre alguerre self-assigned this Sep 18, 2021
@alguerre alguerre mentioned this issue Sep 18, 2021
14 tasks
alguerre added a commit that referenced this issue Sep 21, 2021
alguerre added a commit that referenced this issue Sep 21, 2021
alguerre added a commit that referenced this issue Sep 25, 2021
@alguerre alguerre linked a pull request Sep 25, 2021 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Editor task refactor Code cleaning and refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant