Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed current CI issues with accuracy failing for Pythia model #451

Conversation

bryce13950
Copy link
Collaborator

Description

Lowers the margin of error in the test tests/acceptance/test_hooked_transformer.py to account for recent changes to the model EleutherAI/pythia-70m, which has caused old margin of error to fail in the CI. I am not sure if there should be a more complicated change to the code base to account for this recent change, but this is an option to fix the test at least temporarily, or permanently if it is deemed accurate enough with a margin of 5e-4 instead of 5e-5.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

Copy link
Collaborator

@alan-cooney alan-cooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a sensible solution for now

@alan-cooney alan-cooney merged commit c427735 into TransformerLensOrg:main Nov 23, 2023
8 checks passed
Gallifantjack added a commit to Gallifantjack/TransformerLens that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants