NanoGPT Conversation did not handle case when there were no biases in model #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
convert_nanogpt_weights
had two issues:IGNORE
tensor.When trying to use the function, loading the converted weights into a
HookedTransformer
would fail for lack of the proper tensors. If we're not supposed to checkpoint the masking tensor, then there is a separate issue in whichHookedTransformer
won't load a checkpoint without it there.I have not added any tests or re-written documentation. There are no existing tests and the only documentation that I can find pertaining to this issue is a comment that said the code worked both with and without biases.
Type of change
Please delete options that are not relevant.
Checklist: