Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now this is a draft in order to discuss and experiment with. We still need to add Baichuan 1, and there is currently an issue with compatibility for Baichuan itself for at least one of the models we want to support. A lot of the configuration has been complete. We need to add a config variable for the
use_fast
variable for the tokenizer. Right now it is set to false for a single architecture, but it varies from model to model on Baichuan.Beyond that, there are issues that seem related to #569 and #570 with this model. This model supports both Mandarin and English. At the moment generations are mixing the two languages together, which seems to be an issue with implementation accuracy.
Fixes #622
Type of change
Please delete options that are not relevant.
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist: