Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model baichuan #649

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Model baichuan #649

wants to merge 10 commits into from

Conversation

bryce13950
Copy link
Collaborator

Description

Right now this is a draft in order to discuss and experiment with. We still need to add Baichuan 1, and there is currently an issue with compatibility for Baichuan itself for at least one of the models we want to support. A lot of the configuration has been complete. We need to add a config variable for the use_fast variable for the tokenizer. Right now it is set to false for a single architecture, but it varies from model to model on Baichuan.

Beyond that, there are issues that seem related to #569 and #570 with this model. This model supports both Mandarin and English. At the moment generations are mixing the two languages together, which seems to be an issue with implementation accuracy.

Fixes #622

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [c] I have not rewritten tests relating to key interfaces which would affect backward compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant