Remove duplicate CacheConnectionStringProperties calls (dotnet#683)

TrayanZapryanov · Aug 31, 2020 · 4ae7ee9 · 4ae7ee9
1 parent dbbcde8
commit 4ae7ee9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs
@@ -114,7 +114,6 @@ private static readonly ConcurrentDictionary<string, IList<string>> _ColumnEncry
         public SqlConnection(string connectionString) : this()
         {
             ConnectionString = connectionString;    // setting connection string first so that ConnectionOption is available
-            CacheConnectionStringProperties();
         }
 
         /// <include file='../../../../../../../doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml' path='docs/members[@name="SqlConnection"]/ctorConnectionStringCredential/*' />
@@ -157,7 +156,6 @@ public SqlConnection(string connectionString, SqlCredential credential) : this()
             // else
             //      credential == null:  we should not set "Credential" as this will do additional validation check and
             //      checking pool groups which is not necessary. All necessary operation is already done by calling "ConnectionString = connectionString"
-            CacheConnectionStringProperties();
         }
 
         private SqlConnection(SqlConnection connection)

diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlConnection.cs
@@ -336,7 +336,6 @@ public SqlConnection(string connectionString, SqlCredential credential) : this()
             // else
             //      credential == null:  we should not set "Credential" as this will do additional validation check and
             //      checking pool groups which is not necessary. All necessary operation is already done by calling "ConnectionString = connectionString"
-            CacheConnectionStringProperties();
         }
 
         private SqlConnection(SqlConnection connection)
@@ -3231,5 +3230,3 @@ internal struct MEMMAP
         internal byte[] rgbData;
     }
 } // Microsoft.Data.SqlClient namespace
-
-