feat: add producer interceptor interface #145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abdulsametileri
requested changes
Sep 19, 2024
| @@ -18,10 +18,11 @@ type Writer interface { | |||
| } | |||
|
|
|||
| type producer struct { | |||
| w Writer | |||
| w Writer | |||
| interceptor *ProducerInterceptor | |||
There was a problem hiding this comment.
It is not necessary to use interface pointer. I mean ProducerInterceptor is interface, no need to use *
| } | ||
|
|
||
| func NewProducer(cfg *ProducerConfig) (Producer, error) { | ||
| func NewProducer(cfg *ProducerConfig, interceptor *ProducerInterceptor) (Producer, error) { |
There was a problem hiding this comment.
we can use interceptor ...ProducerInterceptor syntax.
In that way, client can use
- NewProducer(producerConfig)
- NewProducer(producerConfig, interceptor1)
- NewProducer(producerConfig, interceptor1, interceptor2)
| @@ -18,10 +18,11 @@ type Writer interface { | |||
| } | |||
|
|
|||
| type producer struct { | |||
| w Writer | |||
| w Writer | |||
| interceptor *ProducerInterceptor | |||
There was a problem hiding this comment.
I think we can support []ProducerInterceptor, in that way client could implement many interceptors if they want, what do you think?
| XSourceAppValue = "kafka-konsumer" | ||
| ) | ||
|
|
||
| func (i *MockProducerInterceptor) OnProduce(ctx kafka.ProducerInterceptorContext) { |
There was a problem hiding this comment.
I think, stubdata directory is not necessary, we can put this implementation on integration_test
Abdulsametileri
requested changes
Sep 19, 2024
|
|
||
| // When | ||
| err := p.Produce(context.Background(), msg) | ||
| // Then |
There was a problem hiding this comment.
Formatting!: We need to put whitespace between 38 and 39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.