Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings in Sass build #505

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

spohlenz
Copy link
Member

Previous warnings:

WARNING in ./frontend/css/index.scss (./frontend/css/index.scss.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[3].use[2]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[3].use[3]!./frontend/css/index.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 13, column 21 of file:///Users/sam/Projects/Trestle/trestle/frontend/css/core/_theme.scss:13:21:
hue() is deprecated. Suggestion:

color.channel($color, "hue", $space: hsl)

More info: https://sass-lang.com/d/color-functions

13 |     --#{$color}-h: #{hue($value)};


frontend/css/core/_theme.scss 14:22  @import
frontend/css/index.scss 59:9         root stylesheet

 @ ./frontend/css/index.scss
 @ ./frontend/index.js 2:0-26

WARNING in ./frontend/css/index.scss (./frontend/css/index.scss.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[3].use[2]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[3].use[3]!./frontend/css/index.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 14, column 21 of file:///Users/sam/Projects/Trestle/trestle/frontend/css/core/_theme.scss:14:21:
saturation() is deprecated. Suggestion:

color.channel($color, "saturation", $space: hsl)

More info: https://sass-lang.com/d/color-functions

14 |     --#{$color}-s: #{saturation($value)};


frontend/css/core/_theme.scss 15:22  @import
frontend/css/index.scss 59:9         root stylesheet

 @ ./frontend/css/index.scss
 @ ./frontend/index.js 2:0-26

WARNING in ./frontend/css/index.scss (./frontend/css/index.scss.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[3].use[2]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[3].use[3]!./frontend/css/index.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 15, column 21 of file:///Users/sam/Projects/Trestle/trestle/frontend/css/core/_theme.scss:15:21:
lightness() is deprecated. Suggestion:

color.channel($color, "lightness", $space: hsl)

More info: https://sass-lang.com/d/color-functions

15 |     --#{$color}-l: #{lightness($value)};


frontend/css/core/_theme.scss 16:22  @import
frontend/css/index.scss 59:9         root stylesheet

 @ ./frontend/css/index.scss
 @ ./frontend/index.js 2:0-26

WARNING in ./frontend/css/index.scss (./frontend/css/index.scss.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[3].use[2]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[3].use[3]!./frontend/css/index.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 20, column 4 of file:///Users/sam/Projects/Trestle/trestle/frontend/css/components/_scopes.scss:20:4:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

20 |     background: #fafafa;


frontend/css/components/_scopes.scss 21:5  @import
frontend/css/index.scss 48:9               root stylesheet

 @ ./frontend/css/index.scss
 @ ./frontend/index.js 2:0-26

WARNING in ./frontend/css/index.scss (./frontend/css/index.scss.webpack[javascript/auto]!=!./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[3].use[2]!./node_modules/sass-loader/dist/cjs.js??ruleSet[1].rules[3].use[3]!./frontend/css/index.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation Warning on line 20, column 4 of file:///Users/sam/Projects/Trestle/trestle/frontend/css/components/_scopes.scss:20:4:
Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

20 |     background: #fafafa;


frontend/css/components/_scopes.scss 21:5  @import
frontend/css/index.scss 48:9               root stylesheet

 @ ./frontend/css/index.scss
 @ ./frontend/index.js 2:0-26

@coveralls
Copy link

Coverage Status

coverage: 91.41%. remained the same
when pulling e1cee8c on sass-deprecation-warnings
into 88198ce on main.

@spohlenz spohlenz merged commit f405db3 into main Sep 27, 2024
45 checks passed
@spohlenz spohlenz deleted the sass-deprecation-warnings branch September 27, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants