Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO module now behaves according to issue #121. #125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NOhs
Copy link
Collaborator

@NOhs NOhs commented Oct 27, 2020

Apart from the changes in behaviour as described in issue #121, the new implementation

  • gets rid of a lot of Path <-> str back and forth conversions,
  • it removes duplicates by consistently using sets instead of manually cleaning up
  • it tries to more closely use terminology used throughout the project
  • it tries to split up the code into reasonable helper functions
  • it tries to improve the expressiveness of the "main" function

@GPMueller
Copy link
Contributor

GPMueller commented Jul 6, 2021

Unfortunately some conflicts have appeared in 'clang_build/io_tools.py' in the meantime, which I'm not 100% sure how to fix correctly... Would be good to rebase this branch and check what the new CI says.

Edit: I think I merged correctly, but several tests are failing, including

  • test_hello_world_mwe
  • test_mwe_two_targets
  • test_automatic_include_folders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants