Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline does not pass rv-object to final callback #35

Open
nickziv opened this issue Aug 11, 2017 · 1 comment
Open

pipeline does not pass rv-object to final callback #35

nickziv opened this issue Aug 11, 2017 · 1 comment
Assignees
@nickziv

Comments

@nickziv
Copy link
Contributor

nickziv commented Aug 11, 2017 •
edited
Loading

As a result of the work on issue-32, the underlying implementations for pipeline() and waterfall() were refactored. During this refactor, a bug was introduced in which the pipeline() function does not pass the status-object to its final callback. This also affects anything else that's implemented in terms of pipeline(), such as forEachPipeline(). Solution involves adding a new res_type to the opts object we pass to waterfall_impl().

Also, please avoid using version 2.0.0 of vasync, if possible.
@nickziv nickziv self-assigned this Aug 11, 2017
@nickziv
Copy link
Contributor Author

nickziv commented Sep 14, 2017 •
edited
Loading

This bug snuck in, because we didn't have (and I didn't write) pipeline tests. Instead I relied exclusively on waterfall and tryEach tests. This was insufficient, and have added a pipeline test to the tests/ directory which verifies that pipeline is running correctly. It gets executed via the same npm test command as the other tests.

Furthermore, a branch of sdc-docker now doesn't crash with this version of vasync. Our other services are unaffected since they are pinned to older versions.

joyent-automation pushed a commit that referenced this issue Sep 14, 2017
@nickziv
#35 pipeline does not pass rv-object to final callback
548e798 
#36 should bump version and update changes.md
Reviewed by: Julien Gilli <[email protected]>
Approved by: David Pacheco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickziv nickziv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickziv