Skip to content

Commit

Permalink
update ipmitool to version 1.8.19
Browse files Browse the repository at this point in the history
fixes CVE-2020-5208

upstream changelog:
version 1.8.19 2022-08-31
        * Cast type before the left shift
        * sel: Fix the deasserted thresholds inequality
        * man: Update the text for -C option
        * chassis restart_cause: Add new causes
        * sel: Remove redundant "Reserve SEL"
        * zero initialize the recv structure on the stack
        * zero initialize the recv structure on the stack
        * ci: Add support for MacOS-11
        * ci: Remove ubuntu-16.04 support
        * sdr: Fix modifier unit
        * Fix compile error
        * Refactor bridging level detection to dedicated function
        * Fix double bridge detection in get_max_(req|rsp)_data_size()
        * ipmi_mc: Fix the IPM_DEV_FWREV1_MAJOR_MASK
        * helper: Fix stderr file descriptor
        * Fix codefactor-io / CodeFactor warnings
        * Use /run instead of /var/run
        * oem: Update product IDs for YADRO
        * lan: Add processing of get/set specific CCs
        * lan: Refactor pointer style
        * doc: update lanplus doc to reflect default cipher suite change
        * ekanalyzer: Fix internal use area off-by-one bug
        * ekanalyzer frushow: Fix internal area size calc
        * sel: Fix "power supply inactive" flag offset
        * ci: Add support for Ubuntu 20.04
        * ci: Fix Ubuntu builds
        * Fix compiler warning
        * Fix compiler warning
        * Fix compiler warning
        * ci: Update for GitHub Actions v2.274.2
        * free: Fix implicit function declarations
        * Use "#pragma once" for headers
        * Remove unneeded execution bits from C source files and a header file
        * Convert line endings to LF
        * Fixed compiler warning.
        * RPM support: fixed broken build due to use of headers from kernel
        * imbapi: replace __FUNCTION__ to eleminate compiler warnings
        * lanplus: remove unused variable
        * hpmfwupg: Clean up / refactor
        * fru: Fix crashes on 6-bit ASCII strings
        * oem: Add product ID for YADRO VEGMAN
        * configure.ac: add '--location' for curl to follow location
        * configure.ac: replace '-#' by '--progress-bar' with curl
        * Add version info to debug output
        * doc, ci: Fix an error in package name for Windows
        * doc: Fix a small typo in INSTALL
        * RPM support: updated spec file changelog
        * RPM support: simplified build process
        * RPM support: fixed broken RPM build
        * doc: Update INSTALL with Windows info
        * ci: Add Windows/cygwin config
        * doc: Update INSTALL for new CI
        * ci: Add github workflow, drop travis
        * Fix compatibility with OpenBSD and macOS
        * dist: Fix dependencies and cleanup
        * dist: Add missing ipmi_time.h header to packaging
        * configure: Fix compatibility with non-bash systems
        * Finalize refactoring of string comparisons
        * channel: Refactor set_user_access option processing
        * Refactor string comparisons
        * sel: Fix OEM record definition example
        * sdr: harden against bad records
        * fru: fix memory leak in ipmi_spd_print_fru
        * ipmi_sel_set_time: fix strptime() return check
        * hpm: use portable __max() in hpmfwupg
        * hpmfwupg: move variable definition to .c file
        * sel: time: fix null pointer dereference in set
        * fru, sdr: Fix id_string buffer overflows
        * lanp: Fix buffer overflows in get_lan_param_select
        * channel: Fix buffer overflow
        * session: Fix buffer overflow in ipmi_get_session_info
        * fru: Fix buffer overflow in ipmi_spd_print_fru
        * fru: Fix buffer overflow vulnerabilities
        * configure: Drop requirement for curses et. al libs
        * configure: remove some duplicate code
        * doc: Update INSTALL to fix installation errors
        * ipmi_dcmi: fix typo in nm_policy_options initialization.
        * Docs: Add info on packages to install on Ubuntu 16.04
        * chassis: Refactor to get rid of strncmp()
        * chassis: Refactor main for centralized exiting
        * chassis: bootdev: Refactor more
        * chassis: bootdev: Refactor to reduce nesting
        * chassis: bootdev: Fix help message and its formatting
        * chassis: bootparam/bootdev: Refactor for less magic
        * oem: supermicro: Add product codes from IPMICFG
        * doc: Update man page regarding `user set password`
        * user: Cleanup/refactor ipmi_user_password()
        * user: Improve password length handling
        * user: Alter "set password" usage information
        * intf: Add missing function declarations
        * doc: fix URL in README
        * event: Clean up event sending from a file
        * event: Clean up the event sending code
        * event: Fix event submission via SSIF
        * make: Use DESTDIR to install IANA PEN database
        * lanplus: Fix embedded bridged responses handling
        * Update .gitignore
        * mc: Fix reporting of manufacturers > 64K
        * Add installation of enterprise-numbers database
        * Update documentation in regard to IANA PEN registry
        * Use configurable path to IANA PEN registry
        * Load IANA PEN registry from a file
        * dbus: Replace obsolete INCLUDES with AM_CPPFLAGS
        * oem: name change from Newisys to Viking Enterprise Solutions
        * Fix default interface to behave as it did before
        * man: Add documentation for chassis bootmbox
        * man: Update the chassis bootparam section
        * chassis: Add boot initiator mailbox support
        * chassis: Use command-specific completion code parser
        * Add support for command-specific completion codes
        * Add a helper htoipmi24() function
        * Add a helper args2buf() function
        * man: Cleanup the manpage formatting tags
        * create_pen_list: only print if values are set
        * chassis: Refactor to reduce code duplication
        * sdr: Fix segfault on invalid unit types
        * vendor: Add YADRO TATLIN Storage Controller ID
        * exchange-bmc-os-info: Remove dependency on ipmi.service
        * Add mechanism to configure to set the default interface
        * ci: Update INSTALL to reflect recent changes
        * ci: Set up matrix builds with Travis CI
        * Enable Travis build of D-Bus interface
        * add OpenBMC D-Bus interface
        * Fix "ipmitool pef {status,info}" not printing final newline
        * Remove unused include
        * Fix IPMI DCMI message typo
        * open: swap free() calls for free_n()
        * open: checking received msg id against expectation
        * open: fix whitespace
        * Refactor free_n() function
        * fru: swap free() calls for free_n()
        * fru: Fix write chunk reduction code
        * fru: add macro FRU_AREA macros
        * fru: replace magic return codes with macros
        * fru header: add return error codes specific to fru
        * fru: fix ipmi_fru_picmg_ext_edit as bool
        * fru: use bool with ipmi_fru_oemkontron_edit
        * fru: change ipmi_fru_query_new_value to return bool
        * fru: mark ipmi_fru_query_new_value as static
        * fru: add fru_cc_rq2big helper method for code checks
        * fru: cleanup ipmi_fru_upg_ekeying
        * fru: use ipmi_cc defined maros for return codes
        * fru: drop extraneous parentheses on negative returns
        * fru: delete unused variable matchInstance
        * fru: cleanup ipmi_fru_oemkontron_get
        * fru: fixup array bounds checking
        * hpm: Adhere to centralized exiting
        * hpm: Minor refactoring
        * hpm: Fix resource leak
        * sol: Make interface timeout obey the -N option
        * helper: add free_n method to handle clearing pointers
        * cygwin: imb: Fix build error (wchar_t)
        * lanplus: Fix segfault for truncated dcmi response
        * Move led color static array to source file
        * drop unused static arrays
        * move static objects to source file
        * cleanup all unused-parameter warnings
        * use __UNUSED__ macro instead of gcc specific attribute
        * implement __UNUSED__ macro for marking unused
        * Add .dirstamp to .gitignore
        * fru: Fix processing of unspecified board mfg. date
        * [compiler-warnings-fixes] use correct fall through comment
        * [compiler-warnings-fixes] ipmi_start_daemon: check return values
        * [compiler-warnings-fixes] ipmi_sdr.c: remove unused function parameters
        * lan: Fix processing disabled VLAN
        * Make ipmitool respect system locale settings
        * Fix strftime() non-literal argument warning
        * Refactor timestamp handling
        * doc: Update manpage with new contact info
        * lanplus: Refactoring
        * lanplus: Fix -C option processing
        * lanplus: Auto-select 'best' cipher suite available
        * lanplus: Fix compile with deprecated APIs disabled.
        * doc: Update home page links
        * doc: Update formatting of ipmitool man page
        * sensor: Refactor ipmi_sensor_print_fc_threshold()
        * sensor: Add support for csv output
        * plugins: open: Properly enable event receiver (#35)
        * lan: Refactoring: Remove unused function
        * general: Get rid of some unused parameter warnings
        * mc: guid: Implement encoding autodetection
        * mc: guid: Fix timestamp decoding
        * mc: guid: Add support for non-standard encodings
        * mc: guid: Fix byte ordering to follow IPMI spec
        * Refactoring: optimize pointer checks
        * imb: Refactoring: remove duplicate code
        * Refactoring: get rid of superfluous comparisons
        * Refactoring. Improve code reuse ratio.
        * general: Fix several misspellings
        * mc: Fix compiler warnings
        * general: Add array_byteswap() to helper
        * lanplus: Make byteswapping generic
        * framework: Update .gitignore
        * framework: Switch to C11 standard with GNU extensions
        * framework: ci: Add support for Travis CI
        * oem: Add basic support for Quanta
        * intf: Refactoring. Remove unused sendrsp()
        * dummy: Add default dummy socket
        * mc: Fix manufacturer ID masking
        * Refactoring. Remove useless feature test macros.
        * general: Make byteswapping arch-independent
        * sel: Minor refactoring
        * sdr: Refactor/optimize code. No functional changes.
        * Add an option to display all dates in UTC
        * mc: Code refactor to reduce copy-paste ratio
        * mc: watchdog set: Refactor to reduce complexity
        * mc: watchdog set: Fix intr setting
        * mc: watchdog get: Update to match IPMI 2.0 spec
        * mc: watchdog: Add `set` command
        * framework: Make git ignore cscope.out
        * plugins/open: Fix for interrupted select
        * nm: Fix policy range (#12)
        * Replace user_id masks with a macro (#8)
        * fru: internaluse: Fix segmentation fault (#9)
        * dcmi: Refactor
        * ID:508 - Fix segfaults in dcmi command handlers
        * vendor: Add YADRO VESNIN identification
        * ID:491 - Fetch vendor IDs from IANA
        * ID:472 - Fix The Most recent Addition/Erase date
        * ID:480 - Call EVP_CIPHER_CTX_free() instead of EVP_CIPHER_CTX_cleanup()
        * ID:480 - ipmitool coredumps in EVP_CIPHER_CTX_init
        * Make git revision more descriptive
        * ID:477 - fru: Fix decoding of non-text data in get_fru_area_str()
        * ID:479 - ekanalyzer: fix processing of custom mfg. fields
        * ID:478 - ekanalyzer: Fixed decoding of FRU fields
        * Add some more configure/build/editor byproducts to .gitignore
        * Add git hash and dirty mark to ipmitool version
        * Prevent autoreconf from complaining about missing NEWS
        * Add bootstrap support for Mac
        * ID:474 - Compile fix on nonlinux systems
        * ID:461 - Make compiler happier about changes related to OpenSSL 1.1
        * ID:461 - OpenSSL 1.1 compatibility - "error: storage size of 'ctx' isn't known"
  • Loading branch information
spzeidler committed May 18, 2023
1 parent 0a48096 commit c2ccd95
Show file tree
Hide file tree
Showing 9 changed files with 61 additions and 160 deletions.
22 changes: 17 additions & 5 deletions sysutils/ipmitool/Makefile
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
# $NetBSD: Makefile,v 1.25 2020/12/23 05:39:47 mlelstv Exp $
# $NetBSD: Makefile,v 1.26 2023/05/18 08:43:20 spz Exp $
#

DISTNAME= ipmitool-1.8.18
PKGREVISION= 4
DISTNAME= IPMITOOL_1_8_19
PKGNAME= ipmitool-1.8.19
CATEGORIES= sysutils
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=ipmitool/}
MASTER_SITES= ${MASTER_SITE_GITHUB:=ipmitool/}
GITHUB_PROJECT= ipmitool
GITHUB_TAG= IPMITOOL_1_8_19
WRKSRC= ${WRKDIR}/ipmitool-${GITHUB_TAG}

MAINTAINER= [email protected]
HOMEPAGE= http://ipmitool.sourceforge.net/
HOMEPAGE= https://github.com/ipmitool/ipmitool
COMMENT= Command-line utility for managing IPMI devices
LICENSE= modified-bsd

USE_TOOLS= automake autoconf
USE_LIBTOOL= yes

GNU_CONFIGURE= yes
INSTALLATION_DIRS+= share/examples/ipmitool share/doc/ipmitool
Expand All @@ -19,6 +26,11 @@ CONFIGURE_ARGS.SunOS+= --enable-solaris-opt

CFLAGS.NetBSD+= -D_NETBSD_SOURCE

DEPENDS+= iana-enterprise-numbers-[0-9]*:../../net/iana-enterprise-numbers

pre-configure:
cd ${WRKSRC} && ./bootstrap

# ipmitool uses rl_event_hook
.include "../../devel/readline/buildlink3.mk"
.include "../../security/openssl/buildlink3.mk"
Expand Down
4 changes: 2 additions & 2 deletions sysutils/ipmitool/PLIST
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@comment $NetBSD: PLIST,v 1.5 2011/02/17 08:38:56 markd Exp $
@comment $NetBSD: PLIST,v 1.6 2023/05/18 08:43:20 spz Exp $
bin/ipmitool
man/man1/ipmitool.1
man/man8/ipmievd.8
Expand All @@ -7,4 +7,4 @@ share/doc/ipmitool/AUTHORS
share/doc/ipmitool/COPYING
share/doc/ipmitool/ChangeLog
share/doc/ipmitool/README
share/examples/ipmitool/oem_ibm_sel_map
share/ipmitool/oem_ibm_sel_map
15 changes: 6 additions & 9 deletions sysutils/ipmitool/distinfo
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
$NetBSD: distinfo,v 1.13 2021/10/26 11:19:43 nia Exp $
$NetBSD: distinfo,v 1.14 2023/05/18 08:43:20 spz Exp $

BLAKE2s (ipmitool-1.8.18.tar.gz) = cc57ed59520bd0e40bc6d8225733797864400f12d46d003d8deb3da87682cb9f
SHA512 (ipmitool-1.8.18.tar.gz) = 274d424fff079f7628c0f9fe06580937cb9717c809a71b2f5ef97266c6b6c89983b662fbb1f090e2f94861f1799677c8fc6536013828a8a5e6cb239af53e45ab
Size (ipmitool-1.8.18.tar.gz) = 995313 bytes
SHA1 (patch-ad) = 4af586b36f1744d263c66ed28aa17a9f9840a415
SHA1 (patch-ae) = 67828b62b46a30b204dd436681c5ecac39bb29b3
SHA1 (patch-lib_ipmi__cfgp.c) = 3b16d340fce1bdaee66b15430c25f19f4d38ae08
SHA1 (patch-lib_ipmi__main.c) = 4d90e86dda16ea0b596573d88833e348c11ffb24
SHA1 (patch-src_plugins_lanplus_lanplus__crypt__impl.c) = 8aaa1c6328bd6c0559ae9863cad671cdd32ab514
BLAKE2s (IPMITOOL_1_8_19.tar.gz) = 445528e00b5db7d975cf049e20a46ebbe2b2e1fafa6ac5ca7f47064a8217a37a
SHA512 (IPMITOOL_1_8_19.tar.gz) = 2d91706e9feba4b2ce4808eca087b81b842c4292a5840830001919c06ec8babd8f8761b74bb9dcf8fbc7765f028a5b1a192a3c1b643f2adaa157fed6fb0d1ee3
Size (IPMITOOL_1_8_19.tar.gz) = 641383 bytes
SHA1 (patch-ae) = 6819a2a50d9c0a5f33e60b2f73e436ee43dbb717
SHA1 (patch-configure.ac) = 54ffa45c8c518d2ded4c878cdbf81e9dc514bef4
13 changes: 0 additions & 13 deletions sysutils/ipmitool/patches/patch-ad

This file was deleted.

12 changes: 6 additions & 6 deletions sysutils/ipmitool/patches/patch-ae
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
$NetBSD: patch-ae,v 1.1 2011/12/22 19:00:05 drochner Exp $
$NetBSD: patch-ae,v 1.2 2023/05/18 08:43:20 spz Exp $

CVE-2011-4339

--- lib/helper.c.orig 2009-02-25 20:38:52.000000000 +0000
--- lib/helper.c.orig 2022-09-01 18:42:31.000000000 +0000
+++ lib/helper.c
@@ -427,7 +427,6 @@ ipmi_start_daemon(struct ipmi_intf *intf
#endif

chdir("/");
@@ -917,7 +917,6 @@ ipmi_start_daemon(struct ipmi_intf *intf
lprintf(LOG_ERR, "chdir failed: %s (%d)", strerror(errno), errno);
exit(1);
}
- umask(0);

for (fd=0; fd<64; fd++) {
Expand Down
30 changes: 30 additions & 0 deletions sysutils/ipmitool/patches/patch-configure.ac
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
$NetBSD: patch-configure.ac,v 1.1 2023/05/18 08:43:20 spz Exp $

avoid downloading files in the install phase,
depend on net/iana-enterprise-numbers instead

--- configure.ac.orig 2022-09-01 18:42:31.000000000 +0000
+++ configure.ac
@@ -56,21 +56,7 @@ if test "x$exec_prefix" = "xNONE"; then
exec_prefix="$prefix"
fi

-if test "x$WGET" = "x"; then
- if test "x$CURL" = "x"; then
- AC_MSG_WARN([** Neither wget nor curl could be found.])
- AC_MSG_WARN([** IANA PEN database will not be installed by `make install` !])
- else
- DOWNLOAD="$CURL --location --progress-bar"
- AM_CONDITIONAL([DOWNLOAD], [true])
- fi
-else
- DOWNLOAD="$WGET -c -nd -O -"
- AM_CONDITIONAL([DOWNLOAD], [true])
-fi
-
-AC_MSG_WARN([** Download is:])
-AC_MSG_WARN($DOWNLOAD)
+AM_CONDITIONAL([DOWNLOAD], [false])
AC_SUBST(DOWNLOAD, $DOWNLOAD)

dnl
15 changes: 0 additions & 15 deletions sysutils/ipmitool/patches/patch-lib_ipmi__cfgp.c

This file was deleted.

20 changes: 0 additions & 20 deletions sysutils/ipmitool/patches/patch-lib_ipmi__main.c

This file was deleted.

This file was deleted.

0 comments on commit c2ccd95

Please sign in to comment.