Test bazel on windows (open-telemetry#58)

* Test bazelisk on windows * Fix install_bazelisk script * Limit windows bazel testing * Use separate windows_bazel job * s/WIN32/_WIN32/ * Fix windows bazel compilation issue * Fix windows bazel compilation issue
Troels51 · Mar 27, 2020 · 8b3dd9c · 8b3dd9c
1 parent f5bd54c
commit 8b3dd9c
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 3 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -123,6 +123,13 @@ jobs:
       - run: ./ci/setup_windows_ci_environment.ps1
       - run: ./ci/do_ci.ps1 cmake.test
 
+  windows_bazel:
+    executor: win/vs2019
+    steps:
+      - checkout
+      - run: ./ci/install_windows_bazelisk.ps1
+      - run: ./ci/do_ci.ps1 bazel.build
+
   windows_plugin_test:
     executor: win/vs2019
     steps:
@@ -146,4 +153,5 @@ workflows:
       - benchmark
       - osx_test
       - windows
+      - windows_bazel
       - windows_plugin_test
diff --git a/api/include/opentelemetry/nostd/string_view.h b/api/include/opentelemetry/nostd/string_view.h
@@ -20,7 +20,7 @@ namespace nostd
 class string_view
 {
 public:
-  static constexpr std::size_t npos = std::string::npos;
+  static constexpr std::size_t npos = static_cast<std::size_t>(-1);
 
   string_view() noexcept : length_(0), data_(nullptr) {}
 

diff --git a/api/include/opentelemetry/plugin/dynamic_load.h b/api/include/opentelemetry/plugin/dynamic_load.h
@@ -2,7 +2,7 @@
 
 #include <string>
 
-#ifdef WIN32
+#ifdef _WIN32
 #  include "opentelemetry/plugin/detail/dynamic_load_windows.h"
 #else
 #  include "opentelemetry/plugin/detail/dynamic_load_unix.h"

diff --git a/api/include/opentelemetry/plugin/hook.h b/api/include/opentelemetry/plugin/hook.h
@@ -4,7 +4,7 @@
 #include "opentelemetry/plugin/factory.h"
 #include "opentelemetry/version.h"
 
-#ifdef WIN32
+#ifdef _WIN32
 
 /**
  * Cross-platform helper macro to declare the symbol used to load an OpenTelemetry implementation

diff --git a/ci/do_ci.ps1 b/ci/do_ci.ps1
@@ -5,6 +5,9 @@ $action = $args[0]
 
 $SRC_DIR=(Get-Item -Path ".\").FullName
 
+$BAZEL_OPTIONS=""
+$BAZEL_TEST_OPTIONS="$BAZEL_OPTIONS --test_output=errors"
+
 if (!(test-path build)) {
   mkdir build
 }
@@ -18,6 +21,13 @@ $PLUGIN_DIR="$SRC_DIR\plugin"
 $VCPKG_DIR="$SRC_DIR\vcpkg"
 
 switch ($action) {
+  "bazel.build" {
+    bazel build $BAZEL_OPTIONS -- //... -//api/test/... -//sdk/test/...
+    $exit = $LASTEXITCODE
+    if ($exit -ne 0) {
+      exit $exit
+    }
+  }
   "cmake.test" {
     cd "$BUILD_DIR"
     cmake $SRC_DIR `

diff --git a/ci/install_windows_bazelisk.ps1 b/ci/install_windows_bazelisk.ps1
@@ -0,0 +1,8 @@
+$ErrorActionPreference = "Stop"
+trap { $host.SetShouldExit(1) }
+
+$BAZELISK_VERSION="1.3.0"
+$CWD=(Get-Item -Path ".\").FullName
+(new-object System.Net.WebClient). `
+   DownloadFile("https://github.com/bazelbuild/bazelisk/releases/download/v$BAZELISK_VERSION/bazelisk-windows-amd64.exe",
+                "C:\windows\system32\bazel.exe")