Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Intel compiler and MPI in CI #36

Merged
merged 22 commits into from
Jun 29, 2021
Merged

Include Intel compiler and MPI in CI #36

merged 22 commits into from
Jun 29, 2021

Conversation

ageorgou
Copy link
Collaborator

@ageorgou ageorgou commented Jun 17, 2021

  • Install Intel compiler and MPI following oneAPI examples
  • Cache oneAPI (see example)
  • Adjust Actions workflow and tests to run with MPI
    • Avoid installing MKL twice when running with MPI
    • Clean up
  • Make sure Makefile works correctly when combining ci mode and USE_MPI
    • Make USE_MPI behave similar to the other options (MODE, COMPILER)

I don't like this but it seems there's no way to conditionally
set the environment variable. See also
actions/runner#409
Will possibly change to conditional steps later.
The scripts set the PATH (and maybe other variables?) but those are
not preserved across steps. Since the build step is becoming more
distinct between the two compilers, let's try splitting it in two
conditional ones.
@ageorgou ageorgou force-pushed the ci-mpi branch 5 times, most recently from 5c97cce to 0835fcf Compare June 17, 2021 17:57
.github/workflows/tmp.yml Outdated Show resolved Hide resolved
Adding the mpiio option may be required for now but will eventually
be removed.
It's currently failing when run with MPI and > 1 processes
(not just on GitHub Actions, also on CSD3).
Now behaving similar to the other Makefile variables. This also
lets us make the GitHub Actions job a bit simpler.
@ageorgou ageorgou marked this pull request as ready for review June 29, 2021 08:34
Copy link
Collaborator

@JamieJQuinn JamieJQuinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant!

@ageorgou ageorgou merged commit 2652c80 into merge-develop-mpi Jun 29, 2021
@ageorgou ageorgou deleted the ci-mpi branch June 29, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants