Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub actions #49

Merged

Conversation

AdrianDsg
Copy link
Contributor

Hi,
I just discovered this interesting project. I noticed that the GitHub Actions used in the CI workflows are outdated since a while.

I upgraded the GitHub Actions to their latest versions and also updated the versions in the examples in README.md.

Afterwards I added a Dependabot config file to ease furher upgrades.

Copy link
Owner

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this! A few requests, to get the coding-style just right (in my taste, ofc :P)

.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/testing.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AdrianDsg
Copy link
Contributor Author

AdrianDsg commented Dec 7, 2023

While I unfortunately didn't fully understand your stance on YAML formatting I tried my very best to apply your feedback in f545669. I understand that it still might not fit the expectation as I simply applied Red Hat's YAML formatter before.

@TrueBrain TrueBrain force-pushed the adriandsg/upgrade-github-actions branch from f545669 to 1367f5a Compare December 7, 2023 12:58
@TrueBrain
Copy link
Owner

While I unfortunately didn't fully understand your stance on YAML formatting I tried my very best to apply your feedback in f545669. I understand that it still might not fit the expectation as I simply applied Red Hat's YAML formatter before.

No worries, I just fixed it :) It is more about keeping the diff small, so it is readable. All is good now :) Tnx again!

@TrueBrain TrueBrain force-pushed the adriandsg/upgrade-github-actions branch from 1367f5a to d850ade Compare December 7, 2023 12:59
@TrueBrain TrueBrain merged commit 6d09391 into TrueBrain:main Dec 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants