Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy system-related files rather than symlinking them. #469

Closed
2 tasks
acburdine opened this issue Sep 2, 2017 · 3 comments
Closed
2 tasks

Copy system-related files rather than symlinking them. #469

acburdine opened this issue Sep 2, 2017 · 3 comments

Comments

@acburdine
Copy link
Member

There have been several issues raised in the past that are a result of the way Ghost-CLI manages config files for system-related services (e.g. nginx, systemd). Currently, the CLI saves the actual copy of the file into the system/files directory of the install, and then symlinks the file into the correct place on the filesystem. One benefit of this approach is it allows the user that installed Ghost to edit the file without needing sudo permissions.

However, there are several problems:

  1. most system administrators are used to editing the files in their respective locations on the filesystem.
  2. Systemd in particular is somewhat fragile when it comes to symbolic links (see systemd unit file location #414)
  3. Block-storage based VPSes don't work with this approach (see Ghost start fails on reboot when ghost is installed in a digitalocean block storage #390)

Given these issues, we're going to change the approach for handling config files. Instead of symlinking the file into it's location on the filesystem, we will copy it instead. Additionally, we will add a ghost sync command that does its best to synchronize the two different copies of the file.

  • Copy system config files rather than symlink them
  • Add ghost sync command.
@kirrg001
Copy link
Contributor

Instead of symlinking the file into it's location on the filesystem, we will copy it instead.

I am curious, why we have to keep the systemd copies in system/files?

@acburdine
Copy link
Member Author

I guess we probably don't, now that I think about it.

@github-actions
Copy link

github-actions bot commented May 3, 2021

Our bot has automatically marked this issue as stale because there has not been any activity here in some time. The issue will be closed soon if there are no further updates, however we ask that you do not post comments to keep the issue open if you are not actively working on a PR. We keep the issue list minimal so we can keep focus on the most pressing issues. Closed issues can always be reopened if a new contributor is found. Thank you for understanding 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants