Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx dhparam file is generated each time #487

Closed
bery opened this issue Oct 8, 2017 · 1 comment · Fixed by #506
Closed

Nginx dhparam file is generated each time #487

bery opened this issue Oct 8, 2017 · 1 comment · Fixed by #506

Comments

@bery
Copy link

bery commented Oct 8, 2017

This issue is a

  • [x ] Feature Request

Summary

Dhparam file for nginx SSL configuration is generated each time when SSL certificate is issued for a site installed using ghost cli which takes a huge amount of time

Steps to Reproduce (for a bug report)

  1. Install multiple sites without using SSL
  2. Enable SSL support per site

Proposal: Create one dhparam file and use it across all the sites, for example /etc/ssl/dhparam.pem

Technical details (will be automatically output by Ghost-CLI if an error occurs):

  • OS: Ubuntu 16.04
  • Node Version: 6.x
  • Ghost-CLI Version: 1.1.1
  • Environment: Production
  • Command: ghost setup ssl --sslemail={{ ghost_letsencrypt_user }} --no-prompt
@acburdine
Copy link
Member

@bery yup this makes sense - I originally had thought that it was better, security-wise, to have a unique dhparam for each site, but after reading some more into it it looks like it's fine to only generate it once.

I'll take care of this alongside #469.

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Oct 21, 2017
closes TryGhost#487
- put dhparam.pem and ssl-param.conf in nginx snippets directory
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Oct 21, 2017
closes TryGhost#487
- put dhparam.pem and ssl-param.conf in nginx snippets directory
acburdine added a commit that referenced this issue Oct 24, 2017
closes #487
- put dhparam.pem and ssl-param.conf in nginx snippets directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants