-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running ghost setup
should be (more) idempotent
#594
Labels
Comments
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Sep 30, 2018
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Oct 2, 2018
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Oct 11, 2018
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Oct 11, 2018
closes TryGhost#594, TryGhost#588 - cleanup setup command code & improve testability - rework how extensions register setup steps - make it so an errored setup step doesn't break the entire flow
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Oct 11, 2018
closes TryGhost#594, TryGhost#588 - cleanup setup command code & improve testability - rework how extensions register setup steps - make it so an errored setup step doesn't break the entire flow
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Oct 30, 2018
closes TryGhost#594, TryGhost#588 - cleanup setup command code & improve testability - rework how extensions register setup steps - make it so an errored setup step doesn't break the entire flow
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Dec 16, 2018
closes TryGhost#594, TryGhost#588 - cleanup setup command code & improve testability - rework how extensions register setup steps - make it so an errored setup step doesn't break the entire flow
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Jan 26, 2019
closes TryGhost#594, TryGhost#588 - cleanup setup command code & improve testability - rework how extensions register setup steps - make it so an errored setup step doesn't break the entire flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A user reported a case where they ended up with two systemd service files, one called
ghost_<ip address of blog>
and one calledghost_<url of blog>
. Not for sure on how this happened, but based on the current code I have a theory:ghost setup
, gives ip address as urlghost setup
again, but gives the actual domain name this timeIn this case,
ghost setup
could potentially set up two different systemd service files, because the ghost instance "name" is generated by using the url (see here). Quick fix would probably be to skip the setup step that sets the instance name if the name is already set....however it's probably worth investigating further to see if there are more things in the setup command that can be fixed to make it idempotent.If I find more things, I will add them here:
The text was updated successfully, but these errors were encountered: