Port polling has issues with non-localhost ips #643
Assignees
Labels
Comments
acburdine
added a commit
to acburdine/Ghost-CLI
that referenced
this issue
Feb 13, 2018
closes TryGhost#643 - if the host is specified and isn't 0.0.0.0, use the custom host, otherwise use localhost
acburdine
added a commit
that referenced
this issue
Feb 14, 2018
closes #643 - if the host is specified and isn't 0.0.0.0, use the custom host, otherwise use localhost
vikaspotluri123
pushed a commit
to vikaspotluri123/Ghost-CLI
that referenced
this issue
Feb 18, 2018
closes TryGhost#643 - if the host is specified and isn't 0.0.0.0, use the custom host, otherwise use localhost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Link to related slack conversation
Currently the port polling library tries to connect to Ghost on the localhost ip address. This can cause issues if you set your server.host config property to something other than 127.0.0.1, as Ghost will refuse the connection from localhost.
In theory, it should be as simple as passing the
server.hostconfig value as an option to the net.connect function here, but there are couple potential edge cases (e.g. if your ip address is 0.0.0.0 (listen for connections from anywhere).The text was updated successfully, but these errors were encountered: