Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): add default dbpath when db is sqlite #351

Merged
merged 1 commit into from
Jul 14, 2017
Merged

fix(config): add default dbpath when db is sqlite #351

merged 1 commit into from
Jul 14, 2017

Conversation

acburdine
Copy link
Member

closes #349

  • add defaultValue function to dbpath argument

TODO: do a quick sanity check locally and on ubuntu

@acburdine acburdine added this to the 1.0 FINAL milestone Jul 13, 2017
@acburdine
fix(config): add default dbpath when db is sqlite
2a31714 
refs TryGhost#349
- add defaultValue function to dbpath argument
@TryGhost TryGhost deleted a comment from coveralls Jul 14, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.279% when pulling 2a31714 on acburdine:fix/sqlite-path into 9408737 on TryGhost:master.

@acburdine acburdine merged commit 778aafa into TryGhost:master Jul 14, 2017
@acburdine acburdine deleted the fix/sqlite-path branch July 14, 2017 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 FINAL
Development

Successfully merging this pull request may close these issues.

Throws TypeError when installing using --db=sqlite3 flag
2 participants
@acburdine @coveralls