Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Func Wrapper from node, whilst keeping strong linting #58

Closed
4 tasks done
ErisDS opened this issue May 24, 2013 · 2 comments
Closed
4 tasks done

Remove the Func Wrapper from node, whilst keeping strong linting #58

ErisDS opened this issue May 24, 2013 · 2 comments
Assignees
@ErisDS
Milestone
0.2

Comments

@ErisDS
Copy link
Member

ErisDS commented May 24, 2013

  • Node/Server side code should not have a function wrapper or use strict statement
  • Client code should retain the function wrapper and use strict statement
  • Both client & server should conform to the same whitespace style & code standards
  • Both client & server should be fully linted / validated
@ghost ghost assigned ErisDS May 24, 2013
@ErisDS ErisDS mentioned this issue May 24, 2013
Closed
@JohnONolan
Copy link
Member

Punt to 0.3?

@ErisDS
Copy link
Member Author

ErisDS commented Jun 25, 2013

I'm in the middle of it, will be done shortly. I've been "investigating" this for some time, having various lint settings and seeing how they worked out. The work itself is/was minimal.

ErisDS added a commit to ErisDS/Ghost that referenced this issue Jun 25, 2013
@ErisDS
issue TryGhost#58 - removing the iiwf
2c7245e 
In order to remove the iiwf we need to be able to lint backend and frontend code separately.
Changed our devDependency for grunt-jslint to use a fork which has multiTask (PR sent to main repo)
Updated Gruntfile with split rules for the jslint tasks
As a result, a few files failed to pass the new rules, these have been fixed and added to the commit
ErisDS added a commit to ErisDS/Ghost that referenced this issue Jun 25, 2013
@ErisDS
issue TryGhost#58 - removing the iiwf
ba810fb 
Function wrapper and use strict pragma removed from all node files
ErisDS added a commit to ErisDS/Ghost that referenced this issue Jun 25, 2013
@ErisDS
issue TryGhost#58 - frontend jslint
5881528 
Improvements to consistency
@ErisDS ErisDS mentioned this issue Jun 25, 2013
Merged
@ErisDS ErisDS closed this as completed Jun 25, 2013
tegud pushed a commit to tegud/Ghost that referenced this issue Feb 24, 2014
@oswaldoacauan
fix(scripts): Add correct focus on page load. Close TryGhost#58
58ae72b
ErisDS pushed a commit that referenced this issue Aug 28, 2014
@PaulAdamDavis
Add mobile styles for new-user button
cc74113 
Closes #58
ErisDS pushed a commit that referenced this issue Aug 30, 2014
@PaulAdamDavis
Add mobile styles for new-user button
ec60bcf 
Closes #58
ErisDS pushed a commit that referenced this issue Aug 30, 2014
@PaulAdamDavis
Add mobile styles for new-user button
d48a22c 
Closes #58
morficus pushed a commit to morficus/Ghost that referenced this issue Sep 4, 2014
@ErisDS
issue TryGhost#58 - removing the iiwf
e201118 
In order to remove the iiwf we need to be able to lint backend and frontend code separately.
Changed our devDependency for grunt-jslint to use a fork which has multiTask (PR sent to main repo)
Updated Gruntfile with split rules for the jslint tasks
As a result, a few files failed to pass the new rules, these have been fixed and added to the commit
morficus pushed a commit to morficus/Ghost that referenced this issue Sep 4, 2014
@ErisDS
issue TryGhost#58 - removing the iiwf
8a7c0e1 
Function wrapper and use strict pragma removed from all node files
morficus pushed a commit to morficus/Ghost that referenced this issue Sep 4, 2014
@ErisDS
issue TryGhost#58 - frontend jslint
61a269f 
Improvements to consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErisDS ErisDS

Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@ErisDS @JohnONolan