Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost-Admin assets are cached in development mode #7958

Closed
kevinansfield opened this issue Feb 8, 2017 · 0 comments · Fixed by #8058
Closed

Ghost-Admin assets are cached in development mode #7958

kevinansfield opened this issue Feb 8, 2017 · 0 comments · Fixed by #8058
Labels
help wanted [triage] Ideal issues for contributors to help with server / core Issues relating to the server or core of Ghost

Comments

@kevinansfield
Copy link
Member

Issue Summary

Similar to #7812 the admin JS files are being cached when running Ghost in development mode requiring Web Inspector to be open constantly with the "disable cache when open" option checked.

Steps to Reproduce

  1. Start ghost in development mode gulp dev
  2. Open the admin area in a web browser
  3. Make a change to the admin JS files (easiest thing is to add a bit of text to a template)
  4. Refresh the screen, note that the change is not present
  5. Clear the cache or open web inspector with the "disable cache when open" option checked
  6. Refresh the screen, not that the change is now present

We shouldn't be caching any admin assets whilst in development mode as in the best case it creates fiction and in the worst case can cause developers to fall into traps thinking that their changes are broken.

Technical details:

  • Ghost Version: master (needs checking on LTS)
  • Node Version: 4.7.0
  • Browser/OS: Chrome/macOS
@kirrg001 kirrg001 added help wanted [triage] Ideal issues for contributors to help with server / core Issues relating to the server or core of Ghost labels Feb 8, 2017
@ErisDS ErisDS mentioned this issue Feb 10, 2017
Closed
@ErisDS ErisDS mentioned this issue Feb 27, 2017
Closed
14 tasks
@acburdine acburdine mentioned this issue Feb 27, 2017
Merged
acburdine added a commit to acburdine/Ghost that referenced this issue Feb 28, 2017
@acburdine
🎨 fix admin and theme caching issues
2511960 
refs TryGhost#7812, closes TryGhost#7958
- fixes boolean logic wrt to theme cache value from config
- disable cache for admin assets in development
- only add asset hash in production
kirrg001 pushed a commit that referenced this issue Mar 2, 2017
@acburdine @kirrg001
🎨 fix admin and theme caching issues (#8058)
144544e 
refs #7812, closes #7958

- fixes boolean logic wrt to theme cache value from config
- disable cache for admin assets in development
- only add asset hash in production
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted [triage] Ideal issues for contributors to help with server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🎨 fix admin and theme caching issues acburdine/Ghost
2 participants
@kevinansfield @kirrg001