Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added locale for Bengali Language (bn) Just modified signup form for … #20432

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

newazsvn
Copy link
Contributor

Added Bengali (bn) Locale.

  • Only modified signup form for now
  • Soon the other files will be translated

@newazsvn
Copy link
Contributor Author

Translation Complete

@amirsaam
Copy link
Contributor

you need to add your locale code to ghost/i18n/lib/i18n.js too.

p.s. to devs, please remember to release a new version for portal and comments-ui after merging.

@newazsvn
Copy link
Contributor Author

newazsvn commented Jul 1, 2024

you need to add your locale code to ghost/i18n/lib/i18n.js too.

p.s. to devs, please remember to release a new version for portal and comments-ui after merging.

Done. Thanks.

@cathysarisky
Copy link
Contributor

Hello @newazsvn , thanks so much for your work on these! Sorry to see they haven't been merged yet. Do you a few moments more to pick up the newly added strings, including the ones that support the search app? To do that, you'll need to sync your fork. Here are directions if you need them: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork . If you can get your changes updated, I'll put this PR on the list of PRs I'm reminding the dev team about. :)

Copy link
Contributor

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my AI helper!

@9larsons 9larsons enabled auto-merge (squash) October 4, 2024 16:49
@9larsons 9larsons merged commit 44eeed2 into TryGhost:main Oct 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants