🐛 Fixed default recipients setting not showing label filters #20480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagzy
force-pushed
the
fix/SLO-171
branch
2 times, most recently
from
c5c91e5
to
4055edc
Compare
fixes https://linear.app/tryghost/issue/SLO-171 - when default recipients are filtered by a label, we store the filtered label in the `label:slug` format - however, when loading existing label filters, we were fetching labels by ID, instead of slug - with this change, we allow fetching by the relevant key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/tryghost/issue/SLO-171
id, but they're stored byslugin the database settingeditor_default_email_recipients_filterkeyto search forBefore the fix:
https://github.com/TryGhost/Ghost/assets/6225080/aed5fc31-6409-4986-aafe-557073c7f355
After the fix:
https://github.com/TryGhost/Ghost/assets/6225080/f35b2607-5f22-42be-b1bb-92f35ccc9ab7