Fixed "Editor crashed" error showing for a valid 404 #21057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/tryghost/issue/ONC-323 - sometimes posts can be deleted by another user or in a different tab but then edited in an old tab that had the post loaded in the editor - in this situation we were displaying our "Editor crashed" error put in place for the rarer situation where the editor is genuinely in a bad state - added an extra conditional for the bad state and a custom error message for the deleted post state
kevinansfield
force-pushed
the
no-crashed-error-on-genuine-deletion
branch
from
6c0ef15
to
8579d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ONC-323