Admin-only release for ActivityPub #21060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref https://linear.app/tryghost/issue/AP-308/ui-for-deleting-replies - Added `dotdotdot` icon - Added optional `destructive` prop to `Menu` items
ref https://linear.app/tryghost/issue/AP-394 I've also passed the disabled prop, but not sure if it's necessary
ref https://linear.app/tryghost/issue/AP-395 I've also set the disabled prop here too, not sure if necessary
ref https://linear.app/tryghost/issue/AP-397 I think we're gonna want to pass this data into the component long term, but this will do for now, I'm going to look at cleaning up these components in my next B week
ref https://linear.app/tryghost/issue/AP-396 I think it's nicer API to pass in a focused property, rather than an element ref, but I don't have much experience here, so it might be the wrong approach!
ref https://linear.app/tryghost/issue/AP-398 This adds an internal focus state so that we can render the reply box different based on whether or not the textarea is focused!
ref https://linear.app/tryghost/issue/AP-396 We need to use a number instead of boolean here so that the state is always refreshed, otherwise we can run into issues where we set `focused` to true but there's no rerender because it was previously set to true, but unfocused
ref b9d02f8 Because we disabled the button on blue of the textarea, it was being disabled before the click would be handled! Using the mousedown event means that our event gets handled before the blur.
ref https://linear.app/tryghost/issue/AP-395 This is a stopgap solution, because currently we don't have any of our own reply data in the frontend, so this will show the new reply, but it won't be present on page reload. Should be enough for a demo video, but I think we need to either fetch our outbox, or make a new replies endpoint and fetch from there
Otherwise we get green ticks on a PR and then the build fails on main
We didn't catch these because ci type checks weren't running, but they are now!
allouis
force-pushed
the
v5.94.1-admin-with-activitypub-updates
branch
from
5a35ea8
to
06a4400
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.