Improving the use of paths in Ghost #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes TryGhost#392 - adds appRoot, and uses this to calculate other paths - removes path calculations from loader - remove the themedir setting in config.. completely unnecessary - highlights just how important TryGhost#360 is
ErisDS
added a commit
that referenced
this pull request
Aug 12, 2013
Improving the use of paths in Ghost
daniellockyer
pushed a commit
that referenced
this pull request
Jul 20, 2022
refs https://github.com/TryGhost/Team/issues/1577 The call to `edit` was not loading the newsletter relations which is needed by the serializer used by the webhooks service. Co-authored-by: Fabien "egg" O'Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #392