Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate metatitle and url when > 70 chars #4302

Merged
merged 1 commit into from
Oct 17, 2014
Merged

Truncate metatitle and url when > 70 chars #4302

merged 1 commit into from
Oct 17, 2014

Conversation

jaswilli
Copy link
Contributor

Closes #4301

@ErisDS
Copy link
Member

ErisDS commented Oct 17, 2014

lmao @jaswilli I started on this as well, but then @JohnONolan pointed out the slug also needed to be 70 chars, and then I realised that needed to be including the blog url - which is when I got totally stuck :D

@jaswilli
Copy link
Contributor Author

@ErisDS the blog url should be accessible via this.get('config').blogUrl (off the top of my head). I'm happy to close this if you want to take it the rest of the way.

@ErisDS
Copy link
Member

ErisDS commented Oct 17, 2014

I have plenty of other stuff to get on with ;)

@jaswilli jaswilli changed the title Truncate with ellipsis when metatitle > 70 chars Truncate metatitle and url when > 70 chars Oct 17, 2014
ErisDS added a commit that referenced this pull request Oct 17, 2014
Truncate with ellipsis when metatitle > 70 chars
@ErisDS ErisDS merged commit a27cadd into TryGhost:master Oct 17, 2014
@jaswilli jaswilli deleted the issue-4301 branch October 17, 2014 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut off post meta title when it's too long
2 participants