Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default twitter card #4326

Merged
merged 1 commit into from
Oct 23, 2014
Merged

Fixed default twitter card #4326

merged 1 commit into from
Oct 23, 2014

Conversation

lcamacho
Copy link
Contributor

  • according to this Twitter docs the basic twitter card is summary.

@jaswilli
Copy link
Contributor

Hi @lcamacho ,

I confirmed that this is an issue and that the the correct card type should be summary. Can you do me a favor and update your commit message according to: https://github.com/TryGhost/Ghost/wiki/Git-workflow#commit-messages

Since there's no specific issue opened for this PR, feel free to reference the original issue (refs #3900) or use "no issue" for the third line.

Thanks!

@lcamacho
Copy link
Contributor Author

Besides add "no issue" to third line what else should I've to change from commit message?

No issue
- change default Twitter card from content to summary
@jaswilli
Copy link
Contributor

That should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants