Fix for non-unique partial files shadowing each other #5979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #2459 Current behaviour of express-hbs is to load all partials with *.* filter which allows files with same name but different extensions to be mapped to the same name. This way one partial is shadowing the other. Fix now is to give a warning at start up if more than one file resolves to the same name.
|
This was alternatively fixed by TryGhost/express-hbs#93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2459
Current behaviour of express-hbs is to load all partials with . filter
which allows files with same name but different extensions to be mapped
to the same name. This way one partial is shadowing the other.
Fix now is to give a warning at start up if more than one file resolves
to the same name.