Add helpers for facebook & twitter urls #6847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#6534 - this PR assumes that we are now saving usernames only in the database for twitter & facebook - adds a new social links utility which can generate twitter & facebook urls from the username - adds a {{twitter_url}} and {{facebook_url}} helper which uses these - adds a full suite of tests for the helpers & utils
refs TryGhost#6534 - twitter & facebook fields are changing to store usernames only - use the new social url util to generate urls where necessary - update tests
ErisDS
force-pushed
the
social-url-helpers
branch
from
84826e9
to
29c9e8b
Compare
|
Closing in favour of #6848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR assumes that we are now saving usernames only in the database for twitter & facebook
Changing to have usernames only in twitter & Facebook settings/columns currently breaks the frontend as the structured data gets confused.
refs #6534
{{twitter_url}}and{{facebook_url}}helper which uses these