Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove legacy content zero hack #8156

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Mar 14, 2017

refs #7491

  • this hack is so legacy I almost forgot about it 😈
  • in the beginning of Ghost there were no post images
  • someone figured out you could do {{content words="0"}} and it would pull out the first image in your post
  • this was never documented, but enough theme developers found it that when we upgraded downsize to get rid of the bug
  • we needed to add a hack to keep compatibility.
  • This has to die in 🔥 for Ghost 1.0

refs TryGhost#7491

- this hack is so legacy I almost forgot about it 😈
- in the beginning of Ghost there were no post images
- someone figured out you could do {{content words="0"}} and it would pull out the first image in your post
- this was never documented, but enough theme developers found it that when we upgraded downsize to get rid of the bug
- we needed to add a hack to keep compatibility.
- This has to die in 🔥  for Ghost 1.0
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kirrg001 kirrg001 merged commit 5605c96 into TryGhost:master Mar 14, 2017
@ErisDS ErisDS deleted the no-more-content-zero-hack branch March 18, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants