Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where upper case tags in the get helper fails in case sensitive db #9819

Closed
wants to merge 1 commit into from
Closed

Conversation

jtwebman
Copy link
Contributor

closes #9695

This seemed like the best place to do a force to lowercase when a database is case sensitive yet tags and slug is always lowercase.

…sitive db

closes #9695

This seemed like the best place to do a force to lowercase when a database is case sensitive yet tags and slug is always lowercase.
@kirrg001 kirrg001 self-assigned this Aug 24, 2018
@kirrg001
Copy link
Contributor

Thanks! Will look at your PR next week :)

@@ -85,6 +85,18 @@ filter = function filter(Bookshelf) {
},

preProcessFilters: function preProcessFilters() {
/* Lowercase filters for tags and slug no matter how they are passed in */
this._filters.statements = gql.json.replaceStatements(this._filters.statements, {prop: /tags|slug/}, function (statement) {

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the rebase ☹️We replaced GQL and had to refactor the filter plugin.
Let me know if you need a hand, i can help 👍

Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👻I've left one comment!

@kirrg001
Copy link
Contributor

@jtwebman ping 🙂

@jtwebman
Copy link
Contributor Author

@kirrg001 Going to close this PR and open a new one since this part was heavily refactored.

@jtwebman jtwebman closed this Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowercase slug values before sending the query to the database
2 participants