-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue where upper case tags in the get helper fails in case sensitive db #9819
Conversation
…sitive db closes #9695 This seemed like the best place to do a force to lowercase when a database is case sensitive yet tags and slug is always lowercase.
Thanks! Will look at your PR next week :) |
@@ -85,6 +85,18 @@ filter = function filter(Bookshelf) { | |||
}, | |||
|
|||
preProcessFilters: function preProcessFilters() { | |||
/* Lowercase filters for tags and slug no matter how they are passed in */ | |||
this._filters.statements = gql.json.replaceStatements(this._filters.statements, {prop: /tags|slug/}, function (statement) { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the rebase
Let me know if you need a hand, i can help 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👻I've left one comment!
@jtwebman ping 🙂 |
@kirrg001 Going to close this PR and open a new one since this part was heavily refactored. |
closes #9695
This seemed like the best place to do a force to lowercase when a database is case sensitive yet tags and slug is always lowercase.