package.json validation && fixture cleanup #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
packagejson-validation
branch
from
c6b9679
to
095bc63
Compare
kirrg001
changed the title
refs TryGhost#40 - removed package-json-validator dependency, because it can't provide what we need - add semver/validator to validate the package.json on our own (be relaxed with dependencie pinning - so Ghost won't install the dependencies twice)
- this was a true mess
kirrg001
force-pushed
the
packagejson-validation
branch
from
095bc63
to
3133a2d
Compare
- see comments
kirrg001
force-pushed
the
packagejson-validation
branch
from
3133a2d
to
857bb13
Compare
|
Tested with different themes and errors in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!
Fatal errors are chosen via a different issue, see TryGhost/Ghost#8222. The idea behind it is, to select a couple of errors, which are fatal (you can't activate this theme in Ghost). And the other errors are still errors, but not fatal. We will add a little attribute for this.
I've already tested some real themes, looks good so far (for gscan.ghost.org). But need's more testing tomorrow.
I went a bit crazy with the theme fixtures, but it annoyed me very hard!