Skip to content

Commit

Permalink
Fixed uploading release assets on Windows
Browse files Browse the repository at this point in the history
- I foolishly used a bash env var format but Windows uses Powershell
- simplest here is just to remove the env var and pass it in directly
  • Loading branch information
daniellockyer committed Dec 29, 2023
1 parent 83c8c0a commit 8b86e41
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,8 @@ jobs:
retention-days: 7

- name: Upload binaries to GitHub Release
run: yarn upload
run: yarn upload --upload-all ${{ github.token }}
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
env:
GITHUB_TOKEN: ${{ github.token }}

build-qemu:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -162,7 +160,5 @@ jobs:
retention-days: 7

- name: Upload binaries to GitHub Release
run: yarn install --ignore-scripts && yarn upload
run: yarn install --ignore-scripts && yarn upload --upload-all ${{ github.token }}
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
env:
GITHUB_TOKEN: ${{ github.token }}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"install": "prebuild-install -r napi || node-gyp rebuild",
"prebuild": "prebuild --runtime napi --all --verbose",
"rebuild": "node-gyp rebuild",
"upload": "prebuild --verbose --prerelease --upload-all ${GITHUB_TOKEN}",
"upload": "prebuild --verbose --prerelease",
"test": "node test/support/createdb.js && mocha -R spec --timeout 480000"
},
"license": "BSD-3-Clause",
Expand Down

0 comments on commit 8b86e41

Please sign in to comment.