Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build for node-webkit #395

Closed
songziming opened this issue Jan 20, 2015 · 2 comments
Closed

Cannot build for node-webkit #395

songziming opened this issue Jan 20, 2015 · 2 comments

Comments

@songziming
Copy link

I've been trying to compile node-sqlite3 for node-webkit for a whole day, and still not success.

My OS is ubuntu 14.04 64bit, and the command I use is:

sudo npm install sqlite3 --build-from-source --runtime=node-webkit --target_arch=x64 --target="0.11.5"

If I compile using clang, it'll say something like:

  TOUCH Release/obj.target/deps/action_before_build.stamp
  CC(target) Release/obj.target/sqlite3/gen/sqlite-autoconf-3080701/sqlite3.o
clang: error: unknown argument: '-fno-tree-vrp'
clang: error: unknown argument: '-fno-tree-sink'
make: *** [Release/obj.target/sqlite3/gen/sqlite-autoconf-3080701/sqlite3.o] Error 1

If I use gcc toolchain, it'll report an error like:

 CXX(target) Release/obj.target/node_sqlite3/src/database.o
../src/database.cc: In static member function ‘static void node_sqlite3::Database::New(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/database.cc:134:71: error: no matching function for call to ‘v8::Object::Set(v8::Local<v8::String>, v8::Local<v8::String>, v8::PropertyAttribute)’
     args.This()->Set(NanNew("filename"), args[0]->ToString(), ReadOnly);
                                                                       ^
../src/database.cc:134:71: note: candidates are:
In file included from /home/szm/.nw-gyp/0.11.5/src/node.h:76:0,
                 from ../src/database.cc:2:
/home/szm/.nw-gyp/0.11.5/deps/v8/include/v8.h:2116:8: note: bool v8::Object::Set(v8::Handle<v8::Value>, v8::Handle<v8::Value>)
   bool Set(Handle<Value> key, Handle<Value> value);
@Mithgol
Copy link
Contributor

Mithgol commented Jan 24, 2015

That looks like Set vs. ForceSet changes from #369. Those changes has not yet made it to a new npm package of sqlite3.

@springmeyer
Copy link
Contributor

suppor for node-webkit v0.11.x is totally broken with no plan to fix in sight: #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants