-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target new v8 from chromium 38 #369
Target new v8 from chromium 38 #369
Conversation
+ recent atom-shell >= 0.18.0 replaced occurences of v8::Object::Set with 3 arguments with v8::Object::ForceSet
Thanks for digging into this and finding a fix. My sense is that this fix may be more appropriate for https://github.com/rvagg/nan/ if it is resulting from a difference in v8 versions. |
By the way, does it result from a difference in v8 versions or a difference in On an unrelated note, having looked at a failing job's log, it seems that a newer 32-bit node-webkit requires yet another 32-bit library to run. |
I hereby use a GitHub mention and summon @rvagg to look on the PR's changelog and decide if these changes (mostly |
Discussion continued @ nodejs/nan#221 My initial instinct would be to say that |
Searching github for "v8 forceSet" it seems to me, About the failing AppVeyor builds. It seems that there is something else wrong: @Mithgol what to do about the missing lib for [email protected] 32bit? |
In the job log node-webkit reports the error That lib has to be installed by adding a package (containing that lib) to the line 49 of What package does contain that lib? I don't know (yet), but Ubuntu package search may help. |
Thanks, I will look into it. |
@bwin you can ignore this error. If it persists I'll will take a look after merging your fix. It is only breaking for the builds against a custom node.exe on windows built against Visual Studio 2014 (https://github.com/mapbox/node-cpp11) and the problem I think is unrelated to your fix and rather that I need to update the shasums.
Great, once you have |
In the end it was so easy... wasted a lot of time on this, though. But hey, it works. |
Target new v8 from chromium 38
Thanks! Will issue a new release asap. |
Okay, this is now solved: https://ci.appveyor.com/project/Mapbox/node-sqlite3 |
How can the new version be used with node-webkit ?. It's necesary to wait until a new npm release (3.0.5) ? Thanks! |
sqlite3 has an unpublished fix: TryGhost/node-sqlite3#369 Right now this causes npm install to fail and so the 0.11 job is meaningless. This can be reverted when sqlite3 can be built on node > 0.10 and iojs.
This fixes compiling errors for node-webkit v0.11.0 and atom-shell v0.18.0 as reported in #365
v8::Object::Set
in recent versions of chromium (v38) has no overloaded version which takes 3 arguments (as before).I replaced those occurences with
v8::Object::ForceSet
which can take the 3rd argPropertyAttribute
.Travis tests pass, except for the node-webkit-v0.11.0-ia32 one.
I tested it with atom-shell v0.19.4 on ia32 windows and it works. (That's my use-case. Couldn't upgrade past 0.17.2 before.)
This is definitely not my field of expertise, so please feel free to call bullsh**t on this.
@Mithgol your opinion?