-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N api port #1008
N api port #1008
Conversation
Blocked on nodejs/node-addon-api#57 Note the commented RegExp, Integer, and Date support at https://github.com/mapbox/node-sqlite3/blob/48f5e44ae44b21bb6dd409e288249be57f33c3ba/src/statement.cc#L167-L189. This results in:
|
@springmeyer I have managed to implement the IsDate and IsRegExp functions and am working on a PR. However, I found a bug in the current existing port that I'm in the midst of fixing so I'll have an update with both fixes in soon. The PR I'm working on is at mhdawson#3. |
Thank you for the update @anisha-rohra - I'll wait for word here that you've solved the problem. |
Excited to see this 👍 |
@anisha-rohra what is the status of mhdawson#3? Is it ready to pull in here? /cc @mhdawson |
Still working on it with Anisha. In the latest review we realized there is still direct use of libuv that we want to remove as well. Not sure if that is related to the hand Anisha was investigating but it might be so @anisha-rohra is going to look at that first. |
@mhdawson any update on whether mhdawson#3 is ready to test and/or merge? |
@mhdawson when you have an updated branch, please create a new PR again https://github.com/mapbox/node-sqlite3/pulls |
@springmeyer will do, Anisha is working on removing the direct libuv usage which was the last part. Just back from vacation but hope to catch up with her on where she is with that this week. |
PR with the work from #830
Squashed version of #979