-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron osx builds #1041
electron osx builds #1041
Conversation
Bins are building fine, the test suite isn't running because the Travis-CI environment is headless. |
Issue has been resolved. |
Please restart the following job, test all pass, seems like an issue with homebrew: |
@springmeyer Would it be possible to get this change into master so it publishes the binaries correctly to S3? Thanks again for the quick fix @kewde |
I've accepted the invitation, I'll wait for @mapsam for further input. |
@kewde @springmeyer thanks for the ping - this looks good to me 👍 taking a look at the failing job right now |
Ah, looks like this failure isn't related and is happening in other branches. @kewde feel free to merge and publish binaries for electron/osx. Do you think it would suffice to republish on the current version 4.0.2? Otherwise I'd be happy with a 4.1.0 release if that makes sense to you. |
It would suffice I suppose. What the release procedure? Is it just as simple as adding the publish command in the latest commit? @mapsam @springmeyer |
@kewde release procedure is at https://github.com/mapbox/node-sqlite3/blob/master/CONTRIBUTING.md |
Release procedure is documented in the CONTRIBUTING.md here https://github.com/mapbox/node-sqlite3/blob/master/CONTRIBUTING.md#releasing Not sure if you've been added to the NPM org - if not I can hit that final button when ready, just let me know. Once this branch is merged, you can make the release commit directly on master with the @springmeyer any quick ideas on why https://travis-ci.org/mapbox/node-sqlite3/jobs/430224893 is failing? |
Could someone make a npm package release for 4.0.3, I've merged all electron changes. |
@kewde just got set up on npm myself for sqlite3 - 4.0.3 has been published! Thanks so much. |
Just downloaded the pre-built OSX package for Electron! Appreciate all the effort folks 👍 |
@nocodaio please let me know if there are any issues, thanks! |
No description provided.