-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][stalled] ARM Build in Docker in Travis #1149
Conversation
will travis have enough resource to crossbuild ? |
Please see the linked Travis log file. Needs an extra |
Thanks, The PoC is certainly interesting but it does need to follow the same flow as the other release procedures. |
Sure, but I stopped here before spending time on something that might not be merged because there’s something fundamentally off with it. Any other input as to how to proceed? Make tests run, spread to the supported node versions - anything else I should be aware of? |
I'm going to have to consult the Travis docs a bit further, adding the ARM architecture will require additional builds for the different NodeJS versions. Electron also has an ARM version, so if we also want to provide those binaries we are looking at doubling the load of the CI essentially. It does not seem to me that there is a max limit on the amont of jobs, rather just a max limit for each job. |
To make it more production friendly:
Note: You will need to pass the environment variables to the docker command in order to bridge the gap. |
I have not abandoned this, just low on the todo list for the time being, so if anybody else feels like giving it a shot go right ahead. |
See #1362 |
This PR is at this stage a proof of concept of building ARM binary in Docker with Travis.
The first commit comments out the normal build.
The second commit has the real beef:
precise
)This works in Travis up to "Package appears valid" but naturally publish stage fails without the S3 credentials.
Is this something that you would consider merging?
I have not tested the resulting binary yet.
If finalised and merged fixes #418.