Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebuilt: add electron 6.0.0 #1195

Merged
merged 2 commits into from
Aug 16, 2019
Merged

prebuilt: add electron 6.0.0 #1195

merged 2 commits into from
Aug 16, 2019

Conversation

pdesantis
Copy link
Contributor

@pdesantis pdesantis commented Jul 26, 2019

This adds support for Electron 6.0.0. I used the same technique as #1160 and #1180.

Electron 6.0.0 was released on 7/30/2019.
https://electronjs.org/releases/stable#release-notes-for-v600

@pdesantis
Copy link
Contributor Author

I filed a separate issue (#1197) for the failing Travis job, as it seems to be a preexisting issue that isn't caused by these changes.

@kewde kewde closed this Aug 3, 2019
@kewde kewde reopened this Aug 3, 2019
@kewde kewde closed this Aug 3, 2019
@kewde kewde reopened this Aug 3, 2019
@pdesantis
Copy link
Contributor Author

Thanks for fixing the tests @kewde !

@pdesantis
Copy link
Contributor Author

@kewde (or anyone else) - is there anything else needed from me before this can be merged?

@nicolasgere
Copy link

nicolasgere commented Aug 8, 2019

Are there any plans on doing a release with this soon? Electron 6 support would be great for my project. Thanks

@sulf
Copy link

sulf commented Aug 8, 2019

+1 @kewde would be great to have this merged!

@mapsam
Copy link
Contributor

mapsam commented Aug 16, 2019

👍 thanks all - merging this in, and will publish as 4.0.10

@kewde noticing some missing changelog updates for 4.0.8 and 4.0.9 - any chance you could follow up with an update there? Thanks!

@mapsam mapsam merged commit e6c71d3 into TryGhost:master Aug 16, 2019
@mapsam
Copy link
Contributor

mapsam commented Aug 16, 2019

FYI - this will go out in 4.1.0, not 4.0.10, as there are some other changes in master that warrant a minor!

@mapsam
Copy link
Contributor

mapsam commented Aug 16, 2019

[email protected] published with all binaries built! https://travis-ci.org/mapbox/node-sqlite3/builds/572804185

@pdesantis
Copy link
Contributor Author

Awesome, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants